upgrade vitepress to 1.0.0-rc.12 #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
fil/vitepress-1
branch
from
9cca86d to
d82b429
Compare
|
Bug for the green: vuejs/vitepress#2902 The default colors in light mode seem strange and not consistent with the dark mode variants. I computed new purples here: https://observablehq.com/d/4eb7a6328e3dcdb2 |
|
vuejs/vitepress#2902 was closed with rc.12 |
Fil
changed the title
|
With 1.0.0-rc.12 there's an additional underline on the button on the home page. 
|
mbostock
approved these changes
Sep 11, 2023
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* upgrade vitepress to 1.0.0-rc.10 * brand color fixes * 1.0.0-rc.12 * upgrade dependencies * recompute brand colors * fix observable promo button --------- Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(We don't have to merge this, but I want to track the changes so we can be ready when v1.0.0 is released.)
Current release: https://github.com/vuejs/vitepress/releases/tag/v1.0.0-rc.12
Summary:
Details:
I tried upgrading locally, the nav seems to work.
The new styles for code blocks are quite nicer (the light mode now has light backgrounds).
the fork link is now underlined, why not but the underline has two shades, which we'd want to fix either by removing the underline altogether or by having just one shade..
I don't like the dark green they have now put on the selected words in search, the current lighter green is more legible I think.
No other issue detected so far.